Skip to content

gh-151596: Added missing argument 'size' with default value of -1 to TextIOBase.readline#151679

Merged
ZeroIntensity merged 10 commits into
python:mainfrom
Saber0324:fix/textiobase-readline
Jun 21, 2026
Merged

gh-151596: Added missing argument 'size' with default value of -1 to TextIOBase.readline#151679
ZeroIntensity merged 10 commits into
python:mainfrom
Saber0324:fix/textiobase-readline

Conversation

@Saber0324

@Saber0324 Saber0324 commented Jun 18, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2026
Open
ZeroIntensity
ZeroIntensity reviewed Jun 19, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a news entry? This is technically user-facing.

@Saber0324 Saber0324 force-pushed the fix/textiobase-readline branch from dbbc554 to eff30be Compare June 19, 2026 03:32
ZeroIntensity
ZeroIntensity reviewed Jun 20, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-06-18-23-59-46.gh-issue-151596.5ma144.rst Outdated
ZeroIntensity
ZeroIntensity reviewed Jun 21, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close :)

Comment thread Misc/NEWS.d/next/Library/2026-06-18-23-59-46.gh-issue-151596.5ma144.rst Outdated
ZeroIntensity
ZeroIntensity approved these changes Jun 21, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 21, 2026
@ZeroIntensity ZeroIntensity merged commit 30aeeb3 into python:main Jun 21, 2026
61 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

Thanks @Saber0324 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151870 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 21, 2026
@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151871 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 21, 2026
@bedevere-app

bedevere-app Bot commented Jun 21, 2026

Copy link
Copy Markdown

GH-151872 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 21, 2026
@vstinner

vstinner commented Jun 22, 2026

Copy link
Copy Markdown
Member

@ZeroIntensity: I'm not sure that it's a good idea to change readline() API in stable versions (3.13 and 3.14), but I'm fine with changing 3.15 which is not released yet (final release will be in October).

@ZeroIntensity

ZeroIntensity commented Jun 22, 2026

Copy link
Copy Markdown
Member

Yeah, that's why I hesitated on the backports.

I don't know whether this counts as a bug or a feature. I see valid arguments for both. Maybe we should ask the RMs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney cmaloney approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Saber0324 @vstinner @ZeroIntensity @cmaloney